feat: custom tx fee on direct and collaborative send #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
force-pushed
the
feat/send-txfee
branch
2 times, most recently
from
19eff9e to
8b269ca
Compare
theborakompanioni
force-pushed
the
feat/send-txfee
branch
from
8b269ca to
e6ea3f7
Compare
theborakompanioni
changed the title
theborakompanioni
force-pushed
the
feat/send-txfee
branch
from
09b8515 to
36a9459
Compare
This reverts commit 316d66b.
|
Ready for review. Please rebuild the regtest environment with |
|
I really do not like the fee input element. Maybe we can rework this in a future release. @editwentyone |
|
you are right, its way to "big" for such a tiny function. will redesign in the future, for now we need the functionality |
editwentyone
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #696.
Enables specifing the tx fee on the send page for direct and collaborative sends.
Only possible with the newest (unreleased) JM version.
Direct send support is already merged (JoinMarket-Org/joinmarket-clientserver#1597).
Collaborative send is still being reviewed (JoinMarket-Org/joinmarket-clientserver#1612).
TODO:
📸